Add missing events emit in bridge.cairo

[ptisserand]

The functions enable_white_list, set_bridge_l1_addr, set_erc721_class_hash and set_l1_l2_collection_mapping in bridge.cairo lacks of events emitting.

Unit test must be updated to add event check.

[PavitraAgarwal21]

@ptisserand love to take this up when OD hack start.

[saimeunt]

@ptisserand Would love to work on this one, I have some experience in Cairo including unit testing 👌 https://github.com/carbonable-labs/cairo-erc-7498

[Mystic-Nayy]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Simplify core test file structure by moving tests in /src next to code

How I plan on tackling this issue

1. Add event emissions to enable_white_list, set_bridge_l1_addr, set_erc721_class_hash, and set_l1_l2_collection_mapping in bridge.cairo.

2. Include relevant parameters in the events for tracking changes.

3. Update unit tests to verify the correct events are emitted with expected values.

[danielcdz]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello, I'm Daniel Calderón! I'm a passionate software engineer with over 3 years of experience, actively contributing to open-source projects through OnlyDust. I’m also a community moderator at Dojo Coding, where I help new developers get started with blockchain development. Over the past few months, I've contributed to several Starknet projects, including cairo-vm-go by Nethermind. Currently, I’m a Cairo developer at ByteBuilders, working on ByteBeasts, a fully on-chain RPG game built using the Dojo Engine framework. My expertise spans full-stack development, with a focus on backend, frontend, and smart contract development in blockchain ecosystems.

How I plan on tackling this issue

Currently, I'm building a fully on chain game using the Dojo Engine framework, I have good XP with unit testing on Cairo Smart Contracts! I will use the starknet::testing utils to check if the events were emitted properly after applying the changes to the functions.

[aji70]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

i'm a solidity and cairo smart contract developer with over 2 years experience and believe i have the skill set for the task

How I plan on tackling this issue

would create and add the missing events

[saimeunt]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Would love to work on this one, I have some experience in Cairo including unit testing 👌 https://github.com/carbonable-labs/cairo-erc-7498

How I plan on tackling this issue

I will make sure to emit the correct events and test that they were indeed emitted using snfoundry spy and assert_emitted.

[onlydustapp[bot]]

The maintainer ptisserand has assigned saimeunt to this issue via OnlyDust Platform. Good luck!