search

ArkProjectNFTs / bridge

The ArkProject Bridge: seamless transfer of NFTs between ETH L1 & Starknet L2. Smart contracts, user-friendly interface, secure & efficient solution. Experience the future of NFT ownership today
https://bridge.arkproject.dev
Apache License 2.0
23 stars 20 forks source link

Fix : #234 Missing checks for address(0x0) when updating address stat… #240

Closed ryzen-xp closed 1 month ago

ryzen-xp commented 1 month ago

Summary of Changes Made Input Validation in setL1L2CollectionMapping: Added checks to ensure collectionL1 is not address(0) and collectionL2 is not 0 to prevent invalid mappings. Event Emission: Emitted L1L2CollectionMappingUpdated after setting the mapping for transparency.

and add unit test

vercel[bot] commented 1 month ago

@ryzen-xp is attempting to deploy a commit to the Screenshot Team on Vercel.

A member of the Team first needs to authorize it.

ryzen-xp commented 1 month ago

Hello Sir @ptisserand , I change all test name , Can you recheck my PR request .
Thanks!

ryzen-xp commented 1 month ago

Hello Sir @ptisserand , I change all you want to change , Plz Check my PR request .

ryzen-xp commented 1 month ago

@ptisserand sir , can you check again my PR plz.

ryzen-xp commented 1 month ago

Thank you Sir