search

ArkeologeN / node-linkedin

LinkedIn 2.0 wrapper in Node.js
MIT License
163 stars 78 forks source link

Issue 40: Update State Handling in Auth class #48

Closed gi closed 9 years ago

gi commented 9 years ago

This includes pull request #47 updating scope handling.

States should be semi unique to each request per LinkedIn's documentation. This update changes when and how states are generated and how they are stored, maintained, and deleted.

State is no longer a parameter to the initialization of the package. Thus, states are not static (conforming to LinkedIn's documentation).

A state may be supplied to the authorize function in the Auth class by the client software or (if not supplied) generated for them.

A state is deleted upon a successful authorization matching.

nickethan commented 9 years ago

+1 on this... We are having memory leak issues.

ArkeologeN commented 9 years ago

Great work guys! nice pick! Sorry I was on vacations so didn't noticed. Merging!