Arkhist / Hacknet-Pathfinder

Hacknet Labyrinths Modloader in C#
MIT License
108 stars 18 forks source link

Implement Plugin Lists #137

Open Spartan322 opened 2 years ago

Spartan322 commented 2 years ago

A plugin list should be accessible both from the main menu and while in game, it should include:

We could also implement a manner to include:

Any other suggestions for what the plugin should contain should be commented below.

luky92 commented 2 years ago

Ability to disable autoupdate just in case

luky92 commented 2 years ago

What functions does the plug-in hook to

Spartan322 commented 2 years ago

Ability to disable autoupdate just in case

There will be no autoupdate with this feature, at most it will auto-check for updates on start, but will not update automatically, you must press the update button to do so. Even then it will require the PathfinderUpdater plugin.

What functions does the plug-in hook to

I am not sure what you mean. Do you mean to ask how a plugin could use the update and check for update feature? For a while into the future it will only apply to Pathfinder functionality run in this repo, BepInEx.Hacknet,PathfinderAPI, and PathfinderUpdater will be the only plugins that currently allow it. In the future I hope to open this to others after warning them about updates containing dangerous references (which the user will be able to disable) and validating the results as best we can. Plugins will be opt-in for that functionality however.

luky92 commented 2 years ago

No I mean a list of game functions that the plug-in overrides if possible

Spartan322 commented 2 years ago

No I mean a list of game functions that the plug-in overrides if possible

There's no point to that since players won't know what those mean and they hold no relevance even if the player did know, they don't contribute anything to knowledge of the plugin's functionality. They don't even have relevance to compatibility because HarmonyX is designed explicitly to prevent that problem as much as possible. What point does it serve then?

luky92 commented 2 years ago

Well I say that because in games where it happens it usually helps me to learn somewhat so it's sort of personal preference W dniu śr., 3.11.2021 o 08:02 George L. Albany @.***> napisał(a):

No I mean a list of game functions that the plug-in overrides if possible

There's no point to that since players won't know what those mean and they hold no relevance even if the player did know, they don't contribute anything to knowledge of the plugin's functionality. They don't even have relevance to compatibility because Harmony is designed explicitly to prevent that problem as much as possible. What point does it serve then?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Arkhist/Hacknet-Pathfinder/issues/137#issuecomment-958695068, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTM4XY5B5SE4SINXSI3EW3UKDNADANCNFSM5HBSO55A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Spartan322 commented 2 years ago

Well I say that because in games where it happens it usually helps me to learn somewhat so it's sort of personal preference

We're not building systems to learn, everything here is to serve the purpose making the modder's work easier, (and hopefully to give the player capability to be informed about the mods they use) if something doesn't serve that purpose there's not reason to add it. If you want to learn Harmony or BepInEx, they have pretty decent documentation for the most part, if you mean to learn C#, modding with Harmony or BepInEx is the last thing you should be doing, honestly even modding a game is generally a bad methodology for initial learning.

luky92 commented 2 years ago

Well I work as a C# Dev so it's about learning how to mod :)

W dniu śr., 3.11.2021 o 08:12 George L. Albany @.***> napisał(a):

Well I say that because in games where it happens it usually helps me to learn somewhat so it's sort of personal preference

We're not building systems to learn, everything here is to serve the purpose making the modder's work easier, (and hopefully to give the player capability to be informed about the mods they use) if something doesn't serve that purpose there's not reason to add it. If you want to learn Harmony or BepInEx, they have pretty decent documentation for the most part, if you mean to learn C#, modding with Harmony or BepInEx is the last thing you should be doing, honestly even modding a game is generally a bad methodology for initial learning.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Arkhist/Hacknet-Pathfinder/issues/137#issuecomment-958699991, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTM4X4B7MVFRGBLZUEOAS3UKDOFBANCNFSM5HBSO55A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Spartan322 commented 2 years ago

Well I work as a C# Dev so it's about learning how to mod :)

This is offtopic. There is no reason to expect that from this project, and well beyond learning how to mod this project will not teach you how to mod other games, (and it most especially won't teach you good habits you'd need to learn either) no two games will have the same modding solutions even if they use the same systems.

Spartan322 commented 2 years ago

169 currently implements:

This is however crude as there is no text wrapping nor any actual scrolling implemented so there is no way to see offscreen information.