Arkisto-Platform / describo-online

https://describo.github.io
GNU General Public License v3.0
7 stars 2 forks source link

Bug loading data with linked entities - some links are not picked up #54

Closed ptsefton closed 2 years ago

ptsefton commented 2 years ago

Problem: When I load this RO-Crate which contains some Classes, Properties and DefinedTerms for a vocabulary, and use this profile some of the links between items are are not picked up by Describo.

Things linked from the root dataset work OK:

image

But inter-item references get turned into Text fields: image

Even when there are links to in the original crate:

{ "@id": "https://purl.archive.org/textcommons/terms#OrthographyTypeTerms", "@type": "DefinedTermSet", "hasDefinedTerm": [ { "@id": "https://purl.archive.org/textcommons/terms#Handwritten" }, { "@id": "https://purl.archive.org/textcommons/terms#Typewritten" }, { "@id": "https://purl.archive.org/textcommons/terms#Typeset" } ], "name": "OrthographyTypeTerms" },

I have tried re-linking using Describo, and that works, but if I remove the Describo Identifier and re-load the crate it reverts to the behaviour where it does not link.

marcolarosa commented 2 years ago

I doubt the size of the crate is causing the issue but it does make it difficult to work with. Would you be able to produce a slimmed down version of that crate with just the entities needed to trigger the bug? No extraneous properties either please.

ptsefton commented 2 years ago

Ok here's a crate that breaks:

{
  "@context": [
    "https://w3id.org/ro/crate/1.1/context",
    {
      "@vocab": "http://schema.org/"
    },
    {
      "txc": {
        "@id": "http://purl.archive.org/textcommons/terms#"
      }
    },
    {
      "@base": null
    }
  ],
  "@graph": [
    {
      "@id": "ro-crate-metadata.json",
      "@type": "CreativeWork",
      "conformsTo": {
        "@id": "https://w3id.org/ro/crate/1.1"
      },
      "about": {
        "@id": "./"
      },
      "identifier": [
        {
          "@id": "#:localid:describo:6f206c6d-d7e0-4287-8903-6b1629b795c1"
        }
      ]
    },
    {
      "@id": "http://purl.archive.org/textcommons/terms#Phonemic",
      "@type": "DefinedTerm",
      "name": "Phonemic",
      "description": [
        "TODO - Olac definitons are circular"
      ],
      "inDefinedTermSet": [
        {
          "@id": "http://purl.archive.org/textcommons/terms#DerivedTextTypeTerms"
        }
      ],
      "sameAs": [
        "http://www.language-archives.org/REC/type-20020628.html#description/phonemic"
      ],
      "@reverse": {
        "mentions": [
          {
            "@id": "./"
          }
        ]
      }
    },
    {
      "@id": "http://purl.archive.org/textcommons/terms#DerivedTextTypeTerms",
      "@type": "DefinedTermSet",
      "name": "AnnotationTypeTerms",
      "hasDefinedTerm": [
        {
          "@id": "http://purl.archive.org/textcommons/terms#Phonemic"
        }
      ]
    },
    {
      "@id": "./",
      "@type": "Dataset",
      "name": "Language Data Ontology",
      "description": [
        "This is an experimental language data ontology based on OLAC terms for use in the ATAP and LDaCA projects"
      ],
      "mentions": [
        {
          "@id": "http://purl.archive.org/textcommons/terms#Phonemic"
        }
      ],
      "@reverse": {}
    }
  ]
}