Arks-Layer / PSO2ENPatchCSV

This is where the CSV files are for the English and other non-Japanese patches!
https://arks-layer.com
67 stars 185 forks source link

All Tech PP save's effects are written wrong. #308

Closed chaoko99 closed 7 years ago

chaoko99 commented 7 years ago

lblnzi0

PP consumption rate is wrong here, it should be PP cost reduction or something to that effect.

It doesn't make resta cost 2 pp.

alama commented 7 years ago

Noting where the strings are in question:

ui_mainmode.csv AllTechPPSave#0 JP: オールテック<br>PPセイブ EN: All Tech <br>PP Save

ui_mainmode.csv AllTechPPSave#1 JP: 全てのテクニックの消費PPが減少する EN: Reduces the PP consumption of all Techniques.

ui_mainmode.csv PpTecRate#0 JP: PP消費割合 EN: PP Consumption Rate

chaoko99 commented 7 years ago

Resolved?

SynthSy commented 7 years ago

We don't see a problem here. 消費 means consumption; to spend 割合 means rate; ratio; percentage; proportion​.

SynthSy commented 7 years ago

Also, don't know where your math is at, but resta uses 30 PP, what this skill does is reduce that number. 20% of 30 is not 2.

chaoko99 commented 7 years ago

You're nitpicking. My point is that written as is, it is misleading.

SynthSy commented 7 years ago

You're nitpicking. My point is that written as is, it is misleading.

How so?

chaoko99 commented 7 years ago

My math is off. So what? My point stands in that it is a % reduction, not a % multiplication.

Consumption rate implies that your PP cost becomes [cost] * 8%, or 8% of the cost. It's actually lowered by eight percent.

chaoko99 commented 7 years ago

Also: image

PSO2 rounds up, so it'd be 3.

Aida-Enna commented 7 years ago

It fits what SEGA wrote, and if we wanted to sit here and fix all of SEGA's mistakes, we'd just end up with Final Fantasy XIV or Guild Wars 2. It's their dumb phrasing, and unless a large number of people are confused as to the meaning, we're going to go with what they put.

Also, 2 is not 3.

Kyle873 commented 7 years ago

Just to amend something here real quick. PSO2 does not always round up. it almost always truncates.