search

Arksine / moonraker

Web API Server for Klipper
https://moonraker.readthedocs.io
GNU General Public License v3.0
1.05k stars 406 forks source link

power type `uhubctl` without specifying port #872

Closed gongtao0607 closed 1 month ago

gongtao0607 commented 3 months ago

What happened

[power usb]
type: uhubctl
location: 1-1
port: 1

Currently, port and location fields are both mandatory in the config. However, on PI 4B I must not provide port to control the USB power.

uhubctl -l 1-1 -a 0
uhubctl -l 1-1 -a 1

Please consider make it optional.

Client

Fluidd

Browser

Chrome

How to reproduce

[power usb]
type: uhubctl
location: 1-1

Additional information

No response

Arksine commented 3 months ago

Thanks. This should be resolved with commit dfa38a0ddc1ca6025d8903834743c71cb08e2aa1.