Arlodotexe / OwlCore.Storage

The most flexible file system abstraction, ever. Built in partnership with the UWP Community.
15 stars 4 forks source link

ReadOnlyZipArchiveFolder.GetFirstByNameAsync fails to find subfolder #21

Closed yoshiask closed 1 year ago

yoshiask commented 1 year ago

Currently, ReadOnlyZipArchiveFolder is unable to find folders by name. This is because GetFirstByName generates the item ID by simply appending name to the current folder ID, which is correct for files but not virtual folders. This means that GetItemAsync attempts to get a folder using a file's ID, which of course fails. https://github.com/Arlodotexe/OwlCore.Storage/blob/e2d96445f80cfb6e41b46d3d1e20fc0507a52667/src/Archive/ReadOnlyZipArchiveFolder.cs#L165