search

Arlodotexe / OwlCore.Storage

The most flexible file system abstraction, ever. Built in partnership with the UWP Community.
16 stars 4 forks source link

Update SystemFolderWatcher #53

Closed d2dyno1 closed 6 months ago

d2dyno1 commented 6 months ago

This PR fixes an issue with the SystemFolderWatcher implementation where the underlying .NET's FileSystemWatcher did not enable raising events.

This critical bug prevented capturing any file system events whatsoever.

Arlodotexe commented 6 months ago

I'll get this reviewed to ship, but we need to update the CommonTests to include checks for this. If this issue is in more than one place, we'll be able to squash it across all implementations in one go.

d2dyno1 commented 6 months ago

I'll get this reviewed to ship, but we need to update the CommonTests to include checks for this. If this issue is in more than one place, we'll be able to squash it across all implementations in one go.

Could this be shipped first before adding the tests? It's kind of a blocking issue and tests can be added later @Arlodotexe

Arlodotexe commented 6 months ago

@d2dyno1 I added some very basic tests over in this PR on your fork. The changes should appear in this PR once you merge and close that PR.

Unfortunately, these tests don't pass locally. That means there's still something wrong with the SystemFolderWatcher that we aren't catching. Feel free to inspect the tests and the code we're testing, see what you can find.

d2dyno1 commented 6 months ago

@Arlodotexe All checks now pass