Arlodotexe / strix-music

Combine any music sources into a single library. It's your music. Play it your way.
http://www.strixmusic.com
139 stars 4 forks source link

ModelPlugin tests failing on some machines #128

Closed Arlodotexe closed 2 years ago

Arlodotexe commented 2 years ago

Background

When we created the model plugins, we wrote a ton of unit tests. I mean an overkill number of tests, in the unit of thousands of tests after all combinations were run.

The testing of all the different possible combinations for plugin models was done by using enum flags, allowing us to feed every combination to the same unit test method.

We made sure the correct underlying plugin was accessed using a bit of reflection to get the relevant properties, throwing an AccessedException{T}, catching it and making sure the T (which is always the containing class) was what we expected.

The problem

I created the model plugins on a single machine, running Windows 10 21H2 (Build 19044) and Visual Studio 2022 17.1.6. For some reason, a select number of these tests simply fail when using other machines.

The reason why isn't clear, but it's something we need to fix