[fix] Skip empty or whitespace lines in M3U playlists

yoshiask commented 2 years ago

Overview

Closes #137

This PR adds and extra control flow in the M3U parser that ignores empty lines (which previously would have caused parsing to fail entirely, see linked issue). Note that it checks for null or whitespace, rather than simply checking line length. This is because empty lines will skip the line[0] == '#' branch and attempt to create a Uri, which will always fail if the line is empty. Since we have to check for line length anyway, we might as well skip all whitespace lines.

Checklist

This PR meets the following requirements:

[x] Tested and contains NO breaking changes or known regressions.
[x] Tested with the upstream branch merged in.
[ ] Tests have been added for bug fixes / features (or this option is not applicable)
[x] All new code has been documented (or this option is not applicable)
[x] Headers have been added to all new source files (or this option is not applicable)

Additional info

Not provided

Arlodotexe commented 2 years ago

Looks like opening the repo has uncovered a new issue in our build validation when it runs a fork. I'll have to fix this before closing this off.

Arlodotexe commented 2 years ago

/azp run

Arlodotexe commented 2 years ago

Tests have all run and passed on my machine successfully. Waiting on DevOps for other build validation.

Arlodotexe / strix-music