Arlodotexe / strix-music

Combine any music sources into a single library. It's your music. Play it your way.
http://www.strixmusic.com
139 stars 4 forks source link

[breaking] Switched IImageBase to use Stream instead of Uri, added ImageResizerPlugin #213

Closed Arlodotexe closed 2 years ago

Arlodotexe commented 2 years ago

Overview

Closes #185 Closes #186 Progress towards #156

Checklist

This PR meets the following requirements:

Breaking changes

We've removed IImageBase.Uri. We've added IImageBase.OpenStreamAsync, IImageBase.MimeType, and made Height and Width optional, as hints to help optimize rendering.

Migration path: Consumers: Instead of opening the image via the Uri resource, open the image stream directly. Implementors: OpenStreamAsync should directly open a Stream to the image resource.

Additional info

Not provided

Arlodotexe commented 2 years ago

@amaid You need to reset Strix or clear out existing metadata before testing. Image processing was removed, and the image IDs changed too.

Arlodotexe commented 2 years ago

It looks like OneDrive has simply stopped returning images from their API. This isn't something we'll be fixing here.