Arlodotexe / strix-music

Combine any music sources into a single library. It's your music. Play it your way.

http://www.strixmusic.com

139 stars 4 forks source link

Refactor and remove CoreMetadata #221

Closed Arlodotexe closed 2 years ago

Arlodotexe commented 2 years ago

Background

StrixMusic.Sdk.CoreModels.CoreMetadata is a record that holds onto "registration" data for a core. It's used to identify a core before instantiation.

Problem

Logo should not be a Uri. It should be a method that opens a Stream.
SdkVer is not needed.
These properties don't need a separate record.

Solution

[x] Change LogoUri to OpenLogoStreamAsync()
[x] Remove SdkVer
[x] Id, DisplayName and OpenLogoStreamAsync() should go directly onto ICore.
- The corresponding AppModel does not need these properties added.