Arlodotexe / strix-music

Combine any music sources into a single library. It's your music. Play it your way.
http://www.strixmusic.com
139 stars 4 forks source link

[fix] Fixed excessive RAM usage and freezing when viewing tracks in Zune shell. #230

Closed amaid closed 2 years ago

amaid commented 2 years ago

Overview

Closes #227

This fixes the memory allocation due to redundant(n^2) event attachment to ArtistItemsChange event in ZuneTrackCollectionItem for each artists on tracks. The event subscription has been moved from the collection item into the collection to avoid excessive memory allocation.

Checklist

This PR meets the following requirements:

Additional info

Not provided

amaid commented 2 years ago

Wasn't able to fully test. I keep getting a crash now when loading the Zune shell. Sandbox shell is fine. Will try again later.

image

In the end it turned out that the issue is unrelated to this PR but a general issue on the master branch, a new issue has been opened for this:

https://github.com/Arlodotexe/strix-music/issues/231