ArmCord / ArmCord

ArmCord is a custom client designed to enhance your Discord experience while keeping everything lightweight.
https://armcord.app
Open Software License 3.0
1.35k stars 70 forks source link

Screenshare can not reopen after being closed #594

Open SomeAspy opened 2 months ago

SomeAspy commented 2 months ago

Describe the bug Opening the screenshare prompt (Where it asks to select what you want to share) Closing it will throw an error in console and not allow it to be opened again This does not happen if the first screenshare prompt is properly run

(node:101775) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

To Reproduce Steps to reproduce the behavior:

  1. Start a screenshare, but select cancel in the prompt
  2. Attempt to reopen the prompt with the screenshare button
  3. It will not open.

Expected behavior Screenshare prompt can be opened again after being closed

Desktop (please complete the following information):

Notes Point of interest: https://github.com/ArmCord/ArmCord/blob/4559a39b0ac3b84272dca0776232613948538f2a/src/discord/screenshare/main.ts#L27 https://www.electronjs.org/docs/latest/api/session

ASpoonfulOfSalt commented 1 month ago

I'm getting the exact same issue, as well as a friend in my VC. He told me he couldn't screenshare after he accidentally Alt+f4 the wrong window (the screenshare one). Then it didn't pop up. I opened my screenshare window, then closed it by pressing the x button. Now it won't reopen. OS: Windows 11 Method of installation: setup.exe Version: 3.2.7 Armcord

smartfrigde commented 4 weeks ago

Possible fix? https://github.com/ArmCord/ArmCord/commit/6c07aa473e4ae487a457effccb1dd521f0b01dab

SomeAspy commented 4 weeks ago

nope