ArmDeveloperEcosystem / lorawan-library-for-pico

Enable LoRaWAN communications on your Raspberry Pi Pico or any RP2040 based board. 📡
BSD 3-Clause "New" or "Revised" License
125 stars 47 forks source link

Update LoRaMAC Node submodule from version 4.5.1 to 4.6.0 #17

Open ThomasLeister opened 2 years ago

ThomasLeister commented 2 years ago

Because why not? ;-)

Use an updated version with possible version fixes. eeprom-board.c has been adapted to reflect the changed function return types.

sandeepmistry commented 2 years ago

@ThomasLeister thanks for this! How much testing have done with the updated version?

sandeepmistry commented 2 years ago

I can confirm these changes work with the otaa_temperature_led example in North America with the TTN/TTS US915 region!

ThomasLeister commented 2 years ago

So far I have only tested the otaa_temperature_led example with TTN in EU868. I've not used ABP with this library at all, yet. So I guess some more testing might be advisable.

sandeepmistry commented 2 years ago

I'm facing some issues with ABP and these changes, so will hold off merging for now.

If I revert to the current main branch everything is fine.