ArmDeveloperEcosystem / lorawan-library-for-pico

Enable LoRaWAN communications on your Raspberry Pi Pico or any RP2040 based board. 📡
BSD 3-Clause "New" or "Revised" License
125 stars 47 forks source link

Fix of the region from US specific to LORAWAN_REGION #2

Closed jbinko closed 3 years ago

jbinko commented 3 years ago

Fix of the region from US specific to LORAWAN_REGION in config file.

See discussion here: https://www.raspberrypi.org/blog/how-to-add-lorawan-to-raspberry-pi-pico/

Credit goes to BFB who spotted this.

sandeepmistry commented 3 years ago

@jbinko thank you for this pull request!

jbinko commented 3 years ago

Hey Sandeep, how are you? I hope all good and you are safe. My name is Jiri (I live in Europe) and recently I looked on your great work – pico lorawan project https://github.com/sandeepmistry/pico-lorawan and I provided PR which you kindly approved. Do you mind to exchange emails? I’d like to send you an email about pico lorawan project. My email is @.*** Thank you Jiri

From: Sandeep @.> Sent: ĂşterĂ˝ 1. ÄŤervna 2021 12:30 To: @.> Cc: @.>; @.> Subject: Re: [sandeepmistry/pico-lorawan] Fix of the region from US specific to LORAWAN_REGION (#2)

@sandeepmistry approved this pull request.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sandeepmistry/pico-lorawan/pull/2#pullrequestreview-672910765, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AANQS2KKSKLHGH6IYCMPOQTTQSZFJANCNFSM454GOLLQ.