Armaldio / ttv-desktop-lite

The Lightweight Desktop App For Twitch.TV
MIT License
2 stars 0 forks source link

Add "Toast Notifications" For TTV Desktop Lite #11

Open TheRealDannyyy opened 6 years ago

TheRealDannyyy commented 6 years ago

Like Discord, TTV Desktop Lite should use a toast notification system. This will make it possible for Twitch.tv itself to display notifications (e.g. "whispers", "is live") and to show our own.

TTV Desktop Lite itself will have custom toast notifications including (Headline | Description):

Armaldio commented 6 years ago

So, we already have that ?

TheRealDannyyy commented 6 years ago

I think you were using temporally native bubble notifications instead of web toast notifications.

Armaldio commented 6 years ago

What's the difference between the two?

Currently I'm using a native module that shows bubble on w7- in the tray and shows a native metro notification on 8 and 10 That also works for Mac and Linux

Le ven. 7 sept. 2018 à 13:32, TheRealDannyyy notifications@github.com a écrit :

I think you were using temporally native bubble notifications instead of web toast notifications https://developer.mozilla.org/de/docs/Web/API/notification.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Armaldio/ttv-desktop-lite/issues/11#issuecomment-419511741, or mute the thread https://github.com/notifications/unsubscribe-auth/AC8lM-_X2DiUWM1xmPKLg2CEvyhkiaVoks5uYq3FgaJpZM4UPYSw .

TheRealDannyyy commented 6 years ago

The web toasts look better and are required for Twitch Whispers to work.

Armaldio commented 6 years ago

required ?

TheRealDannyyy commented 6 years ago

It's a fundemental feature for Twitch notifications.

I don't understand how those work, aren't toast notifications a feature that all browsers have built-in? Just allow all permissions and use the JS code to trigger our own notifications, if we need to.