Armaldio / ttv-desktop-lite

The Lightweight Desktop App For Twitch.TV
MIT License
2 stars 0 forks source link

Page Zoom "CTRL&+" Broken / Page Zoom Not Saving Properly / Appbar Resized With Shortcut Zoom #23

Open TheRealDannyyy opened 6 years ago

TheRealDannyyy commented 6 years ago

This requires some JS hacking but I'm sure you can figure it out. (https://stackoverflow.com/questions/15233076/prevent-that-a-fixed-element-resizes-when-zooming-on-touchscreen)

TheRealDannyyy commented 6 years ago

If you can't fix this, maybe blocking shortcut zooming (ctrl + wheel ...) and adding "zoom in, zoom out, zoom 100%" in the settings menu could be a workaround. I assume you can with code define to only zoom the webview and not the appbar.

Armaldio commented 6 years ago

I already cannot zoom in current version can you confirm ?

TheRealDannyyy commented 6 years ago

Weird I remember being able to zoom in past versions. Nope cannot zoom either.

Armaldio commented 6 years ago

Update the issue according to the desired behaviour then

TheRealDannyyy commented 6 years ago

Honestly up to you, do what's easier.

Armaldio commented 6 years ago

Do you want to allow resizing or not ?

TheRealDannyyy commented 6 years ago

Yes I want resizing but the method is up to you. (Menu or Default Shortcuts or both.)

TheRealDannyyy commented 6 years ago

@Armaldio I've added a sublabel so that users can see the current zoom level, could you please fetch the value and replace the placeholder text?

Everything else works great.

TheRealDannyyy commented 6 years ago

I've check this out again and pressing Ctrl- - breaks the top bar and needs a manual workaround. You have to replace the following shortcuts with custom webview zooming:

Issue blocked by:

Armaldio commented 6 years ago

Seems fixed

TheRealDannyyy commented 5 years ago

I guess you decided to entirely block shortcuts and make it settings menu only. No problem with that so closing.

Armaldio commented 5 years ago

No, shortcuts are working for me: https://github.com/Armaldio/ttv-desktop-lite/commit/4eafff7e09eef668894e37a22854c95ebc11c7e5#diff-bd086afd87b637879590bdc309e5b891R387

TheRealDannyyy commented 5 years ago

You are right. They work but Ctrl & + isn't for some reason

Armaldio commented 5 years ago

🤔 Might be a keyboard layout related problem, will check, keep this openened

TheRealDannyyy commented 5 years ago

Maybe adding an OR with Crtl + mousewheel up and Crtl + mousewheel down could be good enough as a workaround for special keybord layouts.

The zoom level also resets on restart, it should be saved and applied on pageload (do not apply to Twitchy loading page).

TheRealDannyyy commented 5 years ago

I can also still reproduce the appbar zooming using shortcuts. I would honestly recommend to just removing shortcuts and handle zooming entirely using the settings menu.