Open TheRealDannyyy opened 6 years ago
If you can't fix this, maybe blocking shortcut zooming (ctrl + wheel ...) and adding "zoom in, zoom out, zoom 100%" in the settings menu could be a workaround. I assume you can with code define to only zoom the webview and not the appbar.
I already cannot zoom in current version can you confirm ?
Weird I remember being able to zoom in past versions. Nope cannot zoom either.
Update the issue according to the desired behaviour then
Honestly up to you, do what's easier.
Do you want to allow resizing or not ?
Yes I want resizing but the method is up to you. (Menu or Default Shortcuts or both.)
@Armaldio I've added a sublabel so that users can see the current zoom level, could you please fetch the value and replace the placeholder text?
Everything else works great.
I've check this out again and pressing Ctrl- - breaks the top bar and needs a manual workaround. You have to replace the following shortcuts with custom webview zooming:
Issue blocked by:
Seems fixed
I guess you decided to entirely block shortcuts and make it settings menu only. No problem with that so closing.
No, shortcuts are working for me: https://github.com/Armaldio/ttv-desktop-lite/commit/4eafff7e09eef668894e37a22854c95ebc11c7e5#diff-bd086afd87b637879590bdc309e5b891R387
You are right. They work but Ctrl & + isn't for some reason
🤔 Might be a keyboard layout related problem, will check, keep this openened
Maybe adding an OR with Crtl + mousewheel up and Crtl + mousewheel down could be good enough as a workaround for special keybord layouts.
The zoom level also resets on restart, it should be saved and applied on pageload (do not apply to Twitchy loading page).
I can also still reproduce the appbar zooming using shortcuts. I would honestly recommend to just removing shortcuts and handle zooming entirely using the settings menu.
This requires some JS hacking but I'm sure you can figure it out. (https://stackoverflow.com/questions/15233076/prevent-that-a-fixed-element-resizes-when-zooming-on-touchscreen)