Armax / Pokemon-GO-node-api

Pokemon GO api node.js library
MIT License
875 stars 198 forks source link

No result #178

Closed brettstack closed 8 years ago

brettstack commented 8 years ago

Is it just me or are there a lot of "No result" errors being returned?

} else if (!f_ret || !f_ret.payload || !f_ret.payload[0]) {
    return callback('No result');
}
nathanaelnsmith commented 8 years ago

Not just you. I provided my work around here: #148 I'm not sure what the source of this problem is, but it seems the the session times out.

brettstack commented 8 years ago

Thanks for your response. This is sometimes happening to me immediately after I log in though... And other times just randomly from heartbeat. Are you seeing same behaviour? Maybe the servers are being flakey, or maybe they changed something on the servers... Or maybe I just pulled in something here that's causing it.

WiS3 commented 8 years ago

It happens rarely to me also.. sometimes just after login, and sometimes from heartbeat

nathanaelnsmith commented 8 years ago

I've never seen it happen after login, but maybe it started happening after i implemented my work around

predator747 commented 8 years ago

Same here! I often getting No result

predator747 commented 8 years ago

I heard something that Niantic limited the requests per seconds to 3... so your timeout should be about that before starting a new mapscan

AlexZaccaria commented 8 years ago

Ok, i can confirm this @predator747 ReScans gets No Result within 500ms

if(err)
{
    console.log(err + "["+Pokeio.playerInfo.latitude+", "+Pokeio.playerInfo.longitude+"]");
    setTimeout(function() { Pokeio.Heartbeat(MyHeartbeat); }, 100);
    return;
}

No result[45.44242190000001, 9.161924299999988] No result[45.44242190000001, 9.161924299999988] No result[45.44242190000001, 9.162924299999988] No result[45.44242190000001, 9.162924299999988] No result[45.44242190000001, 9.163924299999987] No result[45.44242190000001, 9.163924299999987] No result[45.44242190000001, 9.164924299999987] No result[45.44242190000001, 9.164924299999987] No result[45.44242190000001, 9.165924299999986] No result[45.44242190000001, 9.165924299999986] No result[45.44242190000001, 9.166924299999986] No result[45.44242190000001, 9.166924299999986] No result[45.44242190000001, 9.167924299999985]

nathanaelnsmith commented 8 years ago

Interesting. I've always had mine set to 5 seconds and I'll only get No result after about an hour

brettstack commented 8 years ago

I wasn't throttling at all. After throttling to every 300ms, I no longer get this. Although still on login I will occasionally...

On Fri, 29 Jul 2016, 09:57 Nathanael Smith, notifications@github.com wrote:

Interesting. I've always had mine set to 5 seconds and I'll only get No result after about an hour

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Armax/Pokemon-GO-node-api/issues/178#issuecomment-236234566, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy6l5EwUXZ9UXqZYnx2LpJOUd2T0-CUks5qajEDgaJpZM4JX4Pa .

trickpattyFH20 commented 8 years ago

I consistently get it on login but I put a timeout fallback after login calls and it all seems to work fine! thanks everyone.

I stopped getting the empty response, instead, I started getting a response but with 0 pokemon and 0 pokestops no matter where I go.

elijthomas commented 8 years ago

I get this too, I've tried throttling my requests to 5 seconds between then and still get no result every second request

andnp commented 8 years ago

I too was seeing this problem. I resolved it for myself by limiting all of my requests (encounter, catch, etc) to one request every 3 seconds. Haven't seen a no response since.

brettstack commented 8 years ago

I changed mine to 10rps with retry logic and works well. Also added retry logic to signin - the fact that it happens on signin makes me think it's not entirely a throttling issue. Might be worth adding retry as an option for the lib instead

On Sat, 30 Jul 2016, 07:23 andnp, notifications@github.com wrote:

I too was seeing this problem. I resolved it for myself by limiting all of my requests (encounter, catch, etc) to one request every 3 seconds. Haven't seen a no response since.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Armax/Pokemon-GO-node-api/issues/178#issuecomment-236367900, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy6l9Y9xOL0LN5yfWSNNnemTFa4eHE4ks5qa15dgaJpZM4JX4Pa .