search

Armax / Pokemon-GO-node-api

Pokemon GO api node.js library
MIT License
875 stars 198 forks source link

update for pokemon.json #223

Closed cpainchaud closed 6 years ago

cpainchaud commented 7 years ago

more descriptions and infos about family and evolutions

RedSparr0w commented 7 years ago

i feel like it should be more like:

      "id":1,
      "num":"001",
      "name":"Bulbasaur",
      "img":"http://www.serebii.net/pokemongo/pokemon/001.png",
      "type":"Grass / Poison",
      "height":"0.71 m",
      "weight":"6.9 kg",
      "candy":"Bulbasaur Candy",
      "cost":25,

more specifically:

      "candy":"Bulbasaur Candy",
      "cost":25,

vs 

      "candy":"25 Bulbasaur Candy",

as then the data can be used better, also Pokemon which don't evolve are currently

      "num":"003",
      "name":"Venusaur",
      "img":"http://www.serebii.net/pokemongo/pokemon/003.png",
      "type":"Grass / Poison",
      "height":"2.01 m",
      "weight":"100.0 kg",
      "candy":"None",

and IMO would be better suited as

      "candy":"Bulbasaur Candy",

without a specified cost but still specifying which candy this Pokemon needs to power up.

cpainchaud commented 7 years ago

OK please see , I have implemented your required changes with new candy_count and added candy bar type to evolved pokes

cpainchaud commented 7 years ago

Please merge! :D