search

Armax / Pokemon-GO-node-api

Pokemon GO api node.js library
MIT License
875 stars 198 forks source link

Safeguarding each callback with try catch #77

Closed firanto closed 8 years ago

firanto commented 8 years ago

When I look at the module's code. There are a lot of multi-level async call using callbacks without any safeguard. If one of those callbacks are throwing exception, the whole thing is collapsed (halted, force closed, crashed). I've try to put a try catch enveloping the init call without any success since it's not the init call who throw the exception, it's subsequent callbacks did (which obviously didn't covered by try-catch block).

Armax commented 8 years ago

@d-pollard maybe forking it, instead of uploading it again will be nice, but at least you give use credits and you used our license.md

Armax commented 8 years ago

@carldanley our issues are not supposed to be used for spamming your repos, you commented with useless things 3/4 issue and linked your repo, also you take a lot of "inspiration" from our repo and you didn't mentioned/credited us

Armax commented 8 years ago

No problem if you want to make your own repo without crediting us for a lot of work that you just reused, but at least stop linking your repo under our issues, I found you linking it under 3/4 issues sometimes unrelated.

Armax commented 8 years ago

My age is unrelated, as I already said, stop linking your repo under our issue, you are not going to help anyone by doing so, you are just trying to get peoples looking at your repo and also didn't give us credits.