Multiple builds map to same Docker image

ArmyCyberInstitute / cmgr

CTF Challenge Manager

Apache License 2.0

18 stars 9 forks source link

Multiple builds map to same Docker image #5

Closed jrolli closed 4 years ago

jrolli commented 4 years ago

The current implementation assumes that the Docker images for a build are unique to that build and will try to remove the images when the build is destroyed. Although the error it returns is printed but otherwise ignored, this is an invalid assumption particularly in more complicated deployment environments where seed reuse may be significant.

jrolli commented 4 years ago

Fixed in 6d18a4b67866d33f704d9f1a6ab604179f6c86a0

Refactored code path so that build IDs are assigned earlier and use the ID for the tag within the Docker "repository".