search

ArnaoutLab / diversity

Partitioned frequency- and similarity-sensitive diversity in Python
MIT License
6 stars 1 forks source link

scipy missing from dependencies #63

Closed chhotii-alex closed 10 months ago

chhotii-alex commented 11 months ago

Thus, if you do pip install without scipy being installed, runtime error.

Do we need the dependency on scipy? Maybe when the scipy API for sparse matrices stabilizes sufficiently, we can point users to a sparse matrix type that quacks so much like an np.ndarray that we don't need to call issparse. This is my dream for the future.

nhongphuc commented 11 months ago

The pyproject.toml file says dependencies = ["numpy==1.24.0", "pandas>=1.5.2", "ray>=2.2.0"]. If we add "scipy==1.10.0" to this list, would that fix the issue ?

chhotii-alex commented 10 months ago

👍