search

Arnau478 / hevi

Hex viewer
https://arnau478.github.io/hevi/
GNU General Public License v3.0
56 stars 2 forks source link

Report errors in red #30

Closed Arnau478 closed 4 weeks ago

Arnau478 commented 2 months ago

Currently errors are reported without ANSI escape code coloring. We should do it if color is enabled. The problem is, some errors can occur before we get to know whether the user wants colors or not.

Arnau478 commented 4 weeks ago

I think I'll make the errors be in red depending exclusively on whether the output supports it, and not the user preference. This ensures consistency, as some errors can happen before we know if the user wants color or not. I think it's a good trade-off between the color and the no-color team. Also, errors are not desired output, so they shouldn't be part of the "ideal workflow".