search

Arnaud73 / ngx-matomo

Matomo (aka. Piwik) web analytics for Angular applications
MIT License
102 stars 48 forks source link

Compatibility with angular 17 #107

Open mlditga opened 9 months ago

mlditga commented 9 months ago

Hello, We are trying to use ngx-matomo with angular 17 but it seems that there is an issue with "@angular/router": "^17.0.6". We get this error: "NullInjectorError: No provider for ActivatedRoute!". It seems similar to this issue: https://github.com/Arnaud73/ngx-matomo/issues/58. Do you plan to release a version for angular 17 anytime soon? Or is there a workaround? Thank you very much!

tarlepp commented 8 months ago

Any update on this? Also this most likely relates to #108

tarlepp commented 8 months ago

Angular 17.1.0 is out and this same issue still exists.

Anyone know if there is fix for this?

tarlepp commented 7 months ago

Angular 17.2.0 is out and this issue is still open.

marchein commented 6 months ago

I am also interested in a fix.

jerryzhch commented 6 months ago

Me too

tarlepp commented 2 months ago

Angular 18 is out, is there any change that @Arnaud73 could take a closer look of those open PR's which fixed this? Or is the only option to start to use another library for this?

Arnaud73 commented 2 months ago

I am currently rewriting this library from scratch to make it fully compatible with Angular 18, with many aditional features I'm currently needing for integrating it into a very large app.

Expect version 3.0 to be published in the coming days.

The most curious of you can have a look at https://github.com/Arnaud73/ngx-matomo/tree/feature/angular-18_support for having a look at the breaking changes (library will be module-less, configuration options will be richer).

tarlepp commented 2 months ago

Great news!

cah-chad-smith03 commented 1 week ago

@Arnaud73 I appreciate you working on getting ng18 fully supported, but apps using ng17 still need the fix in order to use this library. Any chance feature/angular-17-upgrade will be approved?

Would rather use this library than have to fork/maintain a parallel branch just to be compatible with ng17. Thanks.