search

Arnaud73 / ngx-matomo

Matomo (aka. Piwik) web analytics for Angular applications
MIT License
102 stars 48 forks source link

Upgrading doc, Adding Routing support, and more #19

Closed ambroiseRabier closed 5 years ago

ambroiseRabier commented 5 years ago

Disclamer: I have tested the features on my angular app, by copy pasting the code. I haven't tried to make an npm package an import it into my project. Because I am not sure on how I should do it, which npm command I should run.

Nevertheless I think this pull request will make good additions to the library.

Close #17

ambroiseRabier commented 5 years ago

Hello, I have rebased my pull request, can you please review it?

Also, in future, please make all renaming into a single separated commits without others changes. Otherwise git is unable to understand which file has been renamed, it can make rebasing a lot harder.

ambroiseRabier commented 5 years ago

Up.

ambroiseRabier commented 5 years ago

Due to no response, I have made my own version of the lib inpired by this one. I have added few missing methods, simplified doc, integrated theses changes above, and made significantly more DRY code. Only downfall is that I haven't tested matomo async requests. https://github.com/ambroiseRabier/ngx-matomo