search

ArnaudBand / react_space_travel

A web application for a company that provides commercial and scientific space travel services. The application will allow users to book rockets and join selected space missions.
https://holiday-2.herokuapp.com/
2 stars 0 forks source link

Space_Travelers_Hub #22

Open Fatima-hub333 opened 2 years ago

Fatima-hub333 commented 2 years ago

Project Link:

https://github.com/ArnaudBand/react_space_travel/projects/1

Team Members:

@ArnaudBand & @Fatima-hub333 we are two team members who are working on this project.

Whoistolu commented 2 years ago

Hi Team, @Fatima-hub333 and @ArnaudBand

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

N/A

Cheers and Happy coding!

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @whoistolu in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

danmainah commented 2 years ago

Hi @Fatima-hub333 and @ArnaudBand ,

Great work on making the changes requested by a previous reviewer 👏 👏 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlights

✔️ Good design ✔️ Good Description

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Fatima-hub333 commented 2 years ago

can you explain how, please? Because there are 22 cards in total if we divide them among 3 people they should be 7 cards per individual. We are 2 team members so we will assign 14 cards (7 cards per individual). & there are no cards left which we have to work on it. Can you guide us plz?

thecodechaser commented 2 years ago

STATUS: APPROVED 🟢

Hi @ArnaudBand, and @Fatima-hub333👋,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Optional suggestions

I am marking these changes as optional because they were missed by the previous reviewer but I suggest considering them.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.