search

ArnaudBarre / eslint-plugin-react-refresh

Validate that your components can safely be updated with fast refresh
MIT License
198 stars 9 forks source link

Remove plugin from README.md #17

Closed albertreed closed 1 year ago

albertreed commented 1 year ago

This is not necessary and produces an error: ESLint couldn't find the config "react-refresh" to extend from. Please check that the name of the config is correct.

ArnaudBarre commented 1 year ago

Are you using the new configuration format?

The doc clearly shows that adding the plugin to the plugin list is expected: https://eslint.org/docs/latest/use/configure/plugins#use-a-plugin

The error suggest that there is either an issue with the resolution or the installation of the package

albertreed commented 1 year ago

I'm not sure what the "new configuration format" is and I'm not an expert at eslint so totally feel free to close! Just wanted you to know that following the Readme produced an error for me and offer to fix up the docs.

ArnaudBarre commented 1 year ago

Are you sure the rules still works when removing the plugin entry? Are you able to get a warning when a file export both a basic variable and a react component?

albertreed commented 1 year ago

Hey - I found my mistake. It was in plugins all along...from the template I started from. Sorry for the noise!