search

ArnaudBarre / eslint-plugin-react-refresh

Validate that your components can safely be updated with fast refresh
MIT License
198 stars 9 forks source link

Add recommended config #23

Closed nklhtv closed 11 months ago

nklhtv commented 1 year ago

Hi, this lint plugin is the only one that i use custom rules for and i was wondering why there is no recommended config for it?

@adamschachne Would you consider adding { "allowConstantExport": true } to the recommended config too?

ArnaudBarre commented 11 months ago

Hey sorry for the delay. I was hesitating if I should add a config or not. I don't think this a good idea to default to allowConstantExport, but in the same time I prefer it to be simpler to enable.

I know most plugins provide configs, but I don't think this is really a problem to have a some rules manually added to the config, that's part of eslint philosophy to be configurable and I don't see it as bad.

I will maybe revisit in the future, but thanks for showing me that's quite easy to add if needed