search

ArnaudBuchholz / ui5-test-runner

A test runner for UI5 applications enabling parallel execution of tests.
https://arnaudbuchholz.github.io/ui5-test-runner/
MIT License
19 stars 9 forks source link

Using ui5-test-runner opens browser windows for tests with puppeteer >= 23.2.0 #100

Closed heimwege closed 1 week ago

heimwege commented 1 month ago

Describe the bug I increased the version of puppeteer: 22.13.1 -> 23.3.0 When running the tests on my local machine a blank (browser?) window shows up.

image (this is an actual screenshot 😸 )

Tested with ui5-test-runner 5.3.1 and 5.3.3. Used run command

"ui:test:server": "ui5 serve --config ./ui5-test.yaml",
"ui:test:runner": "ui5-test-runner --port 8081 --url http://localhost:8080/test/testsuite.qunit.html --report-generator $/report.js $/junit-xml-report.js --report-dir ./target/QunitReport --coverage true --fail-opa-fast --split-opa --coverage-settings ./.nycrc.json",
"ui:test": "start-server-and-test ui:test:server http://localhost:8080/ ui:test:runner",

As soon as I downgrade puppeteer to 23.1.1 everything is back to normal. Issue seems to come from puppeteer >= 23.2.0

Expected behavior No extra window showing up when executing the tests.

Report Issue not related to any test result

Desktop (please complete the following information):

Additional context None

ArnaudBuchholz commented 1 month ago

Thanks for the submission... I also observed that behavior. Yet, it does not fail the tests. I will check on puppeteer repo to see if they are aware of the issue.

ArnaudBuchholz commented 1 month ago

Tested again with puppeteer@23.4.1, problem still present

ArnaudBuchholz commented 1 month ago

https://github.com/puppeteer/puppeteer/issues/13145

heimwege commented 1 week ago

Fxed with puppeteer v23.6.0