search

ArnaudBuchholz / ui5-test-runner

A test runner for UI5 applications enabling parallel execution of tests.
https://arnaudbuchholz.github.io/ui5-test-runner/
MIT License
19 stars 9 forks source link

Proxy mappings job configuration #34

Closed Juli4nSc closed 1 year ago

Juli4nSc commented 1 year ago

This PR would allow to add custom mappings to the REserve server.

In the ui5-test-runner.json :

{
  ...
  "proxies": [
    {
      "match": "^/otherlib/(.+)",
      "file": "./otherfolder/otherlib/$1"
    }, {
      "match": "^/ui/oDataService/v1/odata/v4/ServiceName/(.+)",
      "url": "http://localhost:18082/odata/v4/ServiceName/$1"
    }
  ]
}
ArnaudBuchholz commented 1 year ago

Hello Julien,

This looks interesting and can be merged in the version 1 branch. Yet, it will be kept as a "hidden" feature (not documented) and I will expose it as a public feature in version 2.

I would propose to create a mapping option that works like the libs one but that enables to customize the list of mappings of the runner server. From a security point of view, I have to make sure that such custom mappings do not interfere with the existing ones that are required for the runner to work properly. It means, these custom mappings will be added nearly to the end of the list of mappings.

Thank you for your contribution