ArnaudBuchholz / ui5-test-runner

A test runner for UI5 applications enabling parallel execution of tests.
https://arnaudbuchholz.github.io/ui5-test-runner/
MIT License
18 stars 9 forks source link

job step generateCoverageReport not working since 3.3.1 #64

Closed FrankVisuals closed 9 months ago

FrankVisuals commented 9 months ago

Since version 3.3.1 (3.3.2 did also not work) I received the following error when running my tests: image

After some investigation I found out that in version 3.3.0 it still worked. I identified these changes as root cause: https://github.com/ArnaudBuchholz/ui5-test-runner/commit/9fdfba049c0a95077f41bfc6526234f9935ab9f5

The request that tries to read the files image has the absolute path to the file set as URI path Bildschirmfoto 2023-09-27 um 12 31 57

Therefore it leads to 404

ArnaudBuchholz commented 9 months ago

Thanks for reporting the issue, can you tell me more about your configuration ? how are the files instrumented ? can you share the report.html ? (Since you blanked out the path, you might not want to share the report.html which contains path) I need to understand why the coverage is getting .ts files, I suspect that - during transpiling - the JS code is automatically instrumented. It also means that you use the remote mode (--url). I shall probably test if the file path is reachable before trying to download it, that would solve this issue. Can you confirm that the coverage files (.nyc_output) contain absolute path ?

ArnaudBuchholz commented 9 months ago

In the meantime, to unblock your workflow, you may use version 3.3.1 using npm i -g ui5-test-runner@3.3.1

ArnaudBuchholz commented 9 months ago

reproduced locally, looks like the assumptions are correct.

ArnaudBuchholz commented 9 months ago

@FrankVisuals I believe the version 3.3.4 addresses this issue, can you confirm the problem is either solved or still occurring ?

FrankVisuals commented 9 months ago

Sorry for my late response @ArnaudBuchholz

I've just tested it with version 3.3.4 - it works now! Thanks for the provided fix