search

ArnaudRinquin / atom-zentabs

Keep the opened tabs amount below sanity.
MIT License
48 stars 26 forks source link

Breaks next/previous tab switching #12

Closed valorin closed 9 years ago

valorin commented 10 years ago

Zentabs breaks next/previous tab switching when it starts removing old tabs. Since it extracts tabs and replaces them randomly, the order gets stuffed up and the order of tabs becomes a weird order, rather than logical left<->right.

To reproduce, open a bunch of tabs, randomly editing different ones in different orders, and keep opening. It will eventually start removing randomly positioned tabs, which breaks the next/previous switcher order.

ArnaudRinquin commented 9 years ago

I have been able to reproduce the bug. Thanks for the report. Even if my plugin seems to break something, I think the fix needs to be done the prev/next tab handling because all my plugin is doing is closing tabs. The prev/next tab handler does not seem to refresh tab order the right way. I'll see what I can do.

oktayacikalin commented 9 years ago

Any progress here?

ArnaudRinquin commented 9 years ago

I just tried to reproduce, without being able to reproduce this time. I think it got fixed in the tab component.

ArnaudRinquin commented 9 years ago

Actually, this seems to break at some point. I really don't think it comes from my code. I am just calling @pane.destroyItem, which is the regular way of closing tabs. The tab view just doesn't take that into account.

ArnaudRinquin commented 9 years ago

Tried to reproduce again, without success. It has probably been fixed in atom/tabs