search

ArnaudRinquin / atom-zentabs

Keep the opened tabs amount below sanity.
MIT License
48 stars 26 forks source link

Close pin tabs #26

Open anatooly opened 9 years ago

anatooly commented 9 years ago

Why closed pinned tabs? 'Close all tabs' - closed pinned tabs, this not right. 'Close Tabs to the Right' closed pinned tabs too, this not right.

I pinned some two tabs. Then I open many other tabs and I need close all without my pinned.

ArnaudRinquin commented 9 years ago

The Close other tabs and Close Tabs to the Right are not implemented by this package but by the core tabs package. This core package has no clue about the pinned feature. There is nothing I can do at this plugin level.

I'll see how to act on the tabs package level but can't promise anything.

vemv commented 9 years ago

Similarly If one presses the shortcut to close a tab, it shouldn't do anything if the current tab is a pinned one.

Actually Chrome doesn't behave like that (one can command + W pinned tabs) but I find that to be nonsense, quite objectively.

Cheers - Victor

ArnaudRinquin commented 8 years ago

Sorry @vemv for the huge answering delay ; I just did not see or forgot about your message.

The pin mechanism is very specific to ZenTabs, not Atom. AFAIK, the closing shortcut cmd+w is something ZenTabs can't override. Maybe I can. Feel free to search API doc for it ;)

ArnaudRinquin commented 8 years ago

FYI, I created a pull request that adds the Pin tab feature to the core tabs components. It will be merge one day (hopefully) so this extension can be updated accordingly.

In the meantime, there is nothing else I can do.