search

ArnaudRinquin / atom-zentabs

Keep the opened tabs amount below sanity.
MIT License
48 stars 26 forks source link

Pin tab not working #61

Open dpadmor opened 2 years ago

dpadmor commented 2 years ago

Show pin in menu but when i click never pinned tab, always show "pin tab"

image

savetheclocktower commented 1 year ago

This pull request broke this behavior by removing the .right-clicked class that gets applied to the tab currently being right-clicked. The author remarks that they removed it because it was “unused,” but I think this was an oversight, since I can discern no other obvious way for a package to know which tab is currently being right-clicked.

Since I'm still using Zentabs through Pulsar, I will probably submit a PR to Pulsar itself to fix this removal.

savetheclocktower commented 1 year ago

The just-released Pulsar v1.102.0 fixes this issue. I just verified that pinning tabs via the context menu works as expected.