Closed kazk closed 3 years ago
I pushed https://github.com/Arnavion/k8s-openapi/compare/pr-105 with your PR + one "Various changes" on top (see the commit message for details). Does that look okay to you?
Kubernetes extensions. Capture any other fields with
#[serde(flatten)] extensions: BTreeMap<String, Value>
, then use that to generate code to addextensions
field.
What's this about?
Does that look okay to you?
Yeah, it looks good to me.
What's this about?
I thought we should preserve schema extensions (e.g., x-kubernetes-list-type
etc. for server side apply). Not sure if users want them or if it makes sense.
It's not a blocker. We don't need to do it now.
Generate code to
impl schemars::JsonSchema
instead of usingserde_json::Value
(#104).See
aee7913
(#105).TODO
#[serde(flatten)] extensions: BTreeMap<String, Value>
, then use that to generate code to addextensions
field.Closes #86