search

Arnavion / k8s-openapi

Rust definitions of the resource types in the Kubernetes client API
Apache License 2.0
373 stars 42 forks source link

Remove support for k8s v1.18 #126

Closed jesperpedersen closed 1 year ago

jesperpedersen commented 1 year ago

Signed-off-by: jesperpedersen jesper.pedersen@redhat.com

jesperpedersen commented 1 year ago

Note, that this pull request enables k8s 1.25 in CI.

I can separate this out if necessary.

Arnavion commented 1 year ago

Remove support for k8s v1.18

I looked at this when I did the kind v0.15.0 update yesterday, and for some reason ACK still lists 1.18 as a supported version, so I'd rather not remove it right now.

Note, that this pull request enables k8s 1.25 in CI.

Ah yes, whoops.

jesperpedersen commented 1 year ago

Commercial vendors may support k8s versions longer internally, but customers on those platform would stick on existing software - e.g. not develop new stuff.

But, feel free to close.

Arnavion commented 1 year ago

Yeah just checked again before I do a release, and it's still there, so I'd rather not remove it for now.

Since Rust and the crates.io ecosystem (including k8s-openapi) generally doesn't have a policy of supporting older version lines, it's probably not uncommon for users to update their Rust deps even though everything else about their setup is old enterprise LTS. For example $dayjob updates Rust and deps even in its multi-year LTS branches, for this reason.

I've taken just the missing CI part of this change.

jesperpedersen commented 1 year ago

No worries - kind 0.15 still has a 1.18 image... although I don't know why