search

Arnavion / libjass

Renders ASS subs in the browser.
Apache License 2.0
174 stars 29 forks source link

Set radius attributes on SVGFEMorphologyElement via setAttribute #83

Closed duncanbeevers closed 7 years ago

duncanbeevers commented 7 years ago

Works around bug in Microsoft Edge where SVGFEMorphologyElement radiusX.baseVal and radiusY.baseVal cannot be set directly. https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/6618301/

Demo of dynamically updating radius x and y properties using this method. http://www.webpackbin.com/NkuWAxTNG

Arnavion commented 7 years ago

This is only one of the three bugs that affect SVG filters in Edge, which is why I haven't bothered to work around it and instead just expect SVG filters support to be disabled for Edge in the renderer settings.

https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/6618454/

https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/6618301/ (this issue)

https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/6618695/

Are you saying that the other two are fixed? I haven't tried Edge in a few months to check.

duncanbeevers commented 7 years ago

I haven't run into the other two.

Arnavion commented 7 years ago

Okay, let me check on my W10 VM.

duncanbeevers commented 7 years ago

https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/6618695/ definitely still exists.

Arnavion commented 7 years ago

All three bugs still exist as of "Microsoft Edge 38.14393.0.0 / Microsoft EdgeHTML 14.14393", which is the latest I get from Windows Update. And since SVG filter effects on HTML elements (3) is what libjass uses this code path for in the first place, there's no point adding code to work around (1) or (2).