search

ArneVogel / concat

Download your vods from twitch in the command line
https://www.arnevogel.com/standalone-concat-version/
GNU General Public License v3.0
205 stars 33 forks source link

Fails if downloading a larger VOD #23

Closed itsmattkc closed 6 years ago

itsmattkc commented 6 years ago

Encountered on Ubuntu 17.10 x86_64. When downloading a large VOD with a lot of chunks, concat's combining phase will sometimes fail with a "Too many open files/ffmpeg error" message. Technically this is a system issue, and can be worked around by increasing ulimit -n (default was 1024 and concat succeeded after setting it to 99999), however it'd be great if concat handled this case internally or if there was an option to not delete chunks after downloading so they could be concatenated manually.

shinji257 commented 6 years ago

A patch has been recently merged that should fix this. Are you able to try the current go code and see if it works?

EDIT: I tested the current code and it took care of a ffmpeg error I was getting that was possibly related to the command length. The VOD was split up into some 6000-7000 2 second segments for some reason.

EDIT: It was a 14-15 hour VOD. Ended up at 20GB in size . If anything that's a good test to show what the change ended up doing since it switches to using ffmpeg's filelist input.

ArneVogel commented 6 years ago

should be fixed with newest release