search

ArneVogel / concat

Download your vods from twitch in the command line
https://www.arnevogel.com/standalone-concat-version/
GNU General Public License v3.0
205 stars 33 forks source link

Progress indicator and audio #52

Closed shilangyu closed 5 years ago

shilangyu commented 5 years ago

Implemented #34 & #50

shilangyu commented 5 years ago

Sorry for a separate PR, forgot to include it in the previous one :/

ArneVogel commented 5 years ago

No problem, are you going to tackle more issues/features or should I merge and create a new release?

shilangyu commented 5 years ago

Was thinking about #50 however I'm not familiar with the twitch API (so I don't know if it's possible to download audio directly), the only thing I can think of is downloading the chunks and just extracting the audio at the end (seems bandwidth heavy for an audio only download tho)

ArneVogel commented 5 years ago

Yes, last time I checked there was no way to download only the audio from a vod. So the only way to give a audio only option would be to convert the video with ffmpeg.

shilangyu commented 5 years ago

Would that be an acceptable implementation? I can code that and add in the Readme that in fact it's downloading the whole vod either way so it won't save any bandwidth

ArneVogel commented 5 years ago

Yes, I think that implementation would still be a benefit for people who dont have any experience with ffmpeg, even when it doesnt save bandwidth. I think two options for audio downloads would be good. One -audio-only where only the audio file is kept and one -audio where both the normal video (not muted) and the audio file is kept.

shilangyu commented 5 years ago

Done! :)