search

ArniDagur / python-adblock

Brave's adblock library in Python
https://pypi.org/project/adblock/
Apache License 2.0
57 stars 5 forks source link

include complete redirect rule feature #59

Closed x0day closed 2 years ago

x0day commented 2 years ago

hi, thanks for this project first, it helps me a lot.

in this PR, I complete some feature about scriptlet injection and redirect rules.

  1. update adblock-rust => 0.4.3
  2. add include_redirect_urls parameter for FilterSet.add_filter_list and FilterSet.add_filters
  3. add Engine.add_resource method.
  4. add adblock.AddResourceError Exception
  5. add redirect_type for BlockerResult
  6. add some tests for these functions.
x0day commented 2 years ago

Some implementations refer to the https://github.com/brave/adblock-rust-ffi.

x0day commented 2 years ago

@ArniDagur still have something not ready to merge?

ArniDagur commented 2 years ago

Thank you for your contribution. This has been merged as https://github.com/ArniDagur/python-adblock/pull/60.

x0day commented 2 years ago

Thank you for your contribution. This has been merged as https://github.com/ArniDagur/python-adblock/pull/60.

can you release a new version on pypi.org? thank you.