search

ArniDagur / python-adblock

Brave's adblock library in Python
https://pypi.org/project/adblock/
Apache License 2.0
57 stars 5 forks source link

Certain selectors are not being returned by the engine. #71

Open alkim0 opened 2 years ago

alkim0 commented 2 years ago

When running url_comsetic_resources, certain hide selectors are not being returned. For example, with ublock's filters.txt, on url_cosmetic_resources("https://google.com"), I would expect:

#atvcap > div:has(h3[role="heading"] > span:has-text(/^Ads/))

to be one of the hide selectors, but that is not returned. For url_cosmetic_resources("https://youtube.com"), I would expect:

ytd-display-ad-renderer:upward(ytd-rich-item-renderer)

to be one of the hide selectors, but that is not returned either.

ArniDagur commented 2 years ago

Might be worth trying again now since I've updated the upstream library to 0.5.6.

alkim0 commented 2 years ago

No go. This seems to a current limitation of the upstream library https://github.com/brave/adblock-rust/issues/145