search

ArniDagur / python-adblock

Brave's adblock library in Python
https://pypi.org/project/adblock/
Apache License 2.0
58 stars 4 forks source link

Maturin 0.14+ complains about PEP 621 compliance #92

Closed mia-0 closed 1 year ago

mia-0 commented 1 year ago

Build output:

  Preparing metadata (pyproject.toml): started
  Running command Preparing metadata (pyproject.toml)
  💥 maturin failed
    Caused by: The following metadata fields in `package.metadata.maturin` section of Cargo.toml are removed since maturin 0.14.0: classifier, requires-python, please set them in pyproject.toml as PEP 621 specifies.
  Error running maturin: Command '['maturin', 'pep517', 'write-dist-info', '--metadata-directory', '/tmp/pip-modern-metadata-8aq2njbg', '--interpreter', '/usr/bin/python3.8']' returned non-zero exit status 1.
  Checking for Rust toolchain....
  Running `maturin pep517 write-dist-info --metadata-directory /tmp/pip-modern-metadata-8aq2njbg --interpreter /usr/bin/python3.8`
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
  full command: /usr/bin/python3.8 /usr/lib/python3.8/site-packages/pip/_vendor/pep517/in_process/_in_process.py prepare_metadata_for_build_wheel /tmp/tmpvvdid7xy
  cwd: /home/abuild/rpmbuild/BUILD/python-adblock-0.6.0
  Preparing metadata (pyproject.toml): finished with status 'error'
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
ArniDagur commented 1 year ago

Has your use case been fixed after the merge of https://github.com/ArniDagur/python-adblock/pull/91?

mia-0 commented 1 year ago

On Tuesday, March 28, 2023 3:59:09 PM CEST Árni Dagur wrote:

Has your use case been fixed after the merge of https://github.com/ArniDagur/python-adblock/pull/91?

Oh, missed that one, sorry. I’m packaging this for openSUSE and I’m using the PyPI release, so this isn’t included. The interim patch I made to get it to build is functionally equivalent so yes, this works.