Monitor and control Daikin/Rotex (hybrid/Altherma) heat pumps via the 2-wire P1/P2 thermostat interface with an ATmega328P, ESP8266, and electronics. The P1P2Serial library and P1P2Monitor program perform low-level bus operation, the P1P2-bridge-esp8266 program interprets data from/to MQTT supporting Home Assistant MQTT discovery. P1P2Serial may also be used for other Japanese Home Bus System based standards: DIII-NET (F1/F2) bus, Mitsubishi M-Net bus, Toshiba TCC-Link, Hitachi H-link, Panasonic/Sanyo SIII-Net, Haier, York, and others.
Other
324
stars
62
forks
source link
Omit headers and CRC in tables describing packets #21
OK, I know that this is a big change and you may not agree with it. But I think that it would be helpful, because this documentation file is too long and overcrowded.
So I propose to omit headers and CRC from these tables. Tables would only describe payload data. Information from headers is already in headings (packet type and response/request). I have also included a simple one line summary of the header before each table (see previous pull request).
Also, because we already have a general overview of the packet structure (header, payload data, CRC) here (https://github.com/Arnold-n/P1P2Serial/blob/master/doc/README.md), we do not need to repeat the whole packet in these tables. Lets focus on payload data.
Bytes are renumbered starting with first byte of payload data. I keep your convention that first byte in payload data is 0 (rather than 1).
If you approve this pull request, I will change all remaining tables.
OK, I know that this is a big change and you may not agree with it. But I think that it would be helpful, because this documentation file is too long and overcrowded.
So I propose to omit headers and CRC from these tables. Tables would only describe payload data. Information from headers is already in headings (packet type and response/request). I have also included a simple one line summary of the header before each table (see previous pull request).
Also, because we already have a general overview of the packet structure (header, payload data, CRC) here (https://github.com/Arnold-n/P1P2Serial/blob/master/doc/README.md), we do not need to repeat the whole packet in these tables. Lets focus on payload data.
Bytes are renumbered starting with first byte of payload data. I keep your convention that first byte in payload data is 0 (rather than 1).
If you approve this pull request, I will change all remaining tables.