search

Arnold-n / P1P2MQTT

Monitor and control Daikin/Rotex (hybrid/Altherma) heat pumps via the 2-wire P1/P2 thermostat interface with an ATmega328P, ESP8266, and electronics. The P1P2Serial library and P1P2Monitor program perform low-level bus operation, the P1P2-bridge-esp8266 program interprets data from/to MQTT supporting Home Assistant MQTT discovery. P1P2Serial may also be used for other Japanese Home Bus System based standards: DIII-NET (F1/F2) bus, Mitsubishi M-Net bus, Toshiba TCC-Link, Hitachi H-link, Panasonic/Sanyo SIII-Net, Haier, York, and others.
Other
324 stars 62 forks source link

add needed returns for non-void functions #28

Closed fishbone-git closed 2 years ago

fishbone-git commented 2 years ago

I didn't do much of a review to see if this is the right return value but as a non-void function it shoudl return something. Arduino IDE clearly assumes some sort of default, but platformio will throw an error if there isn't a return for all cases of the function

Arnold-n commented 2 years ago

Thanks @fishbone-git ! Please don't spend too much time on this file as it is end-of-life, and will be replaced.