ArnoldSmith86 / virtualtabletop

a virtual surface in the browser on which you can play board, dice and card games
https://virtualtabletop.io
GNU General Public License v3.0
172 stars 31 forks source link

Rooms removing variations of games #157

Closed Casbuild closed 1 year ago

Casbuild commented 3 years ago

Today myself and @96LawDawg LawDawg have been losing work with rooms resetting. For @96LawDawg LawDawg, they have just ben going to older save states of games.

I have had bigger problems and have lost all the games in one of my rooms and have variations continuously deleting from others.

Before: Before

After: After

robartsd commented 3 years ago

I have lost work due to disconnections without being aware of them for some time. I haven't noticed any problems where it wasn't just that the room went back to a previous state. Certainly could have a better system for checking that the current state is in sync with the server.

ArnoldSmith86 commented 3 years ago

Please note that disconnections can only affect the current room - not anything in the games list. If you see your change in the games list, it went to the server and back.

robartsd commented 3 years ago

Please note that disconnections can only affect the current room - not anything in the games list. If you see your change in the games list, it went to the server and back.

Come to think of it, I have noticed this - the inability to update the games list because I was disconnected.

robartsd commented 3 years ago

Just experienced this in one of my rooms.

I had an old version of Rummy Tiles loaded from the library in the room. I edited the room's Rummy Tiles game and tried adding a variant from the public library, selecting Rummy Tiles. All games were removed from the room.

rogerl50 commented 3 years ago

I was just doing some coding in a room, and while I was just thinking, the room contents disappeared, replaced by the initial empty room screen. The console log says WebSocket closed c05d:16:1556 connecting to wss://virtualtabletop.io c05d:16:1274 WebSocket error: [object Event] c05d:16:1492 WebSocket closed c05d:16:1556 Firefox can’t establish a connection to the server at wss://virtualtabletop.io/. c05d:16:1311 connecting to wss://virtualtabletop.io c05d:16:1274 WebSocket error: [object Event] c05d:16:1492 WebSocket closed c05d:16:1556 Firefox can’t establish a connection to the server at wss://virtualtabletop.io/. c05d:16:1311 connecting to wss://virtualtabletop.io c05d:16:1274

Update: the room was still there, but it had reverted to the pre-edit state (unfortunately I hadn't done any saves).

96LawDawg commented 1 year ago

This issue would no longer be possible based on the new UI. Closed.