search

ArnoldSmith86 / virtualtabletop

a virtual surface in the browser on which you can play board, dice and card games
https://virtualtabletop.io
GNU General Public License v3.0
167 stars 31 forks source link

Avoid Setting Inline Styles #219

Open robartsd opened 3 years ago

robartsd commented 3 years ago

Inline styles can be problematic for using style sheets because the style sheet can never have higher specificity. For supported style properties, we should prefer setting css variables inline and applying the variables in the style sheet. This would be particularly useful for our use of transform, so that an advanced game designers could apply their own transformations in addition to the platform supplied transformations by adding platform supplied css variables in their custom transform property. This would also make it easier to have edit mode styles override game mode styles (eliminate need for !important).

rogerl50 commented 2 years ago

@robartsd Is this still a valid issue?