search

ArnoldSmith86 / virtualtabletop

a virtual surface in the browser on which you can play board, dice and card games
https://virtualtabletop.io
GNU General Public License v3.0
173 stars 31 forks source link

ensure that the game is rendered in light mode #2288

Closed ArnoldSmith86 closed 2 months ago

ArnoldSmith86 commented 2 months ago

The browser might make decent assumptions about how to render overlays in dark mode but the game usually just looks horrible.

We should still properly support dark mode in the rest of the UI but that is a bit of work.

This fixes #2278 because the iframe gets an opaque background if it has a different color-scheme setting than the parent document.

This also fixes a crash when the value of the html card face object is not a string.

ArnoldSmith86 commented 2 months ago

PR-SERVER-BOT: You can play around with it here: https://test.virtualtabletop.io/PR-2288/pr-test (or any other room on that server)