search

ArnoldSmith86 / virtualtabletop

a virtual surface in the browser on which you can play board, dice and card games
https://virtualtabletop.io
GNU General Public License v3.0
173 stars 31 forks source link

conflict detection doesn't trigger when removing a widget and setting parent to it #2360

Open ArnoldSmith86 opened 2 weeks ago

ArnoldSmith86 commented 2 weeks ago

If one client sends a delta that removes a widget and another client sends a delta that adds another widget to the not yet removed widget, the conflict detection doesn't trigger.

This (and probably some other cases like deck) need to be checked and simply trigger conflict resolution (re-sending game state to the second client).

96LawDawg commented 2 weeks ago

This sounds like it could potentially be the source of the mysterious disappearing card problem.

rogerl50 commented 2 weeks ago

Note that in my case, when this happened, indeed a card had vanished in addition to the client crashes.